Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA-256 checksums to the curl-bash-install.sh #145

Open
michalrus opened this issue Feb 3, 2025 · 0 comments
Open

Add SHA-256 checksums to the curl-bash-install.sh #145

michalrus opened this issue Feb 3, 2025 · 0 comments
Assignees

Comments

@michalrus
Copy link
Member

Follow-up to:

Context

Right now we’re not testing that the downloaded archive is what we expect.

HTTP doesn’t validate it on its own.

In the recent GitHub outage, we got a broken archive from them (#139 (review)), so it can happen.

Then, the error was obvious, and it was impossible to unpack the archive, but it could be more subtle.

@michalrus michalrus self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant