Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate clean shutdown (SIGINT, SIGTERM, Ctrl+C on Windows) #31

Open
michalrus opened this issue Oct 31, 2024 · 0 comments
Open

Investigate clean shutdown (SIGINT, SIGTERM, Ctrl+C on Windows) #31

michalrus opened this issue Oct 31, 2024 · 0 comments

Comments

@michalrus
Copy link
Collaborator

michalrus commented Oct 31, 2024 •
edited
Loading

Detection is easy with tokio, see tokio::signal::unix or tokio::signal::ctrl_c.

But do we need to do anything? Wait for certain tasks to finish? It's probably better to do that.

We also need to wait for Prometheus setup to finish. This was detected by @vladimirvolek in integration tests (GHA run log), where the app is shut down after a successful test, and before Prometheus has a chance to finish its setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michalrus