Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store ABI records on its own table #223

Open
3 tasks
pikonha opened this issue Oct 7, 2024 · 1 comment
Open
3 tasks

store ABI records on its own table #223

pikonha opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pikonha
Copy link
Contributor

pikonha commented Oct 7, 2024

Feature Request

Since ENS doesn't have the concept of reserved keys on the texts table, we need to decouple the ABI from the texts table.

Describe Preferred Solution

  • Create a ABI table
  • Remove the ABI reserved key from the texts database
  • Redirect setABI calls to the newly created table

QA Replication steps

  1. Create a 2LD (e.g techno.eth)
  2. Set its resolver to be the database resolver
  3. Set a ABI record through the ABIResolver interface:
function setABI(
    bytes32 node,
    uint256 contentType,
    bytes calldata data
)
  1. Check whether this record is being correctly fetched
@pikonha pikonha added the enhancement New feature or request label Oct 7, 2024
@pikonha pikonha added this to the Database Resolver on mainnet milestone Oct 7, 2024
@pikonha pikonha self-assigned this Oct 7, 2024
@pikonha pikonha moved this to 🔖 TODO in ENS Oct 7, 2024
@pikonha pikonha added this to ENS Oct 7, 2024
@pikonha
Copy link
Contributor Author

pikonha commented Oct 14, 2024

haven't really found any usage of this on mainnet/sepolia, and it is taking a bit longer than expected to accomplish this. that said, I'm gonna deprioritize this in favor of #221

@pikonha pikonha moved this from 🛠️ In Progress to ⛰️ Backlog in ENS Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ⛰️ Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant