Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegisterParams return ERC-20 token address for payment #237

Open
pikonha opened this issue Nov 5, 2024 · 0 comments
Open

RegisterParams return ERC-20 token address for payment #237

pikonha opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pikonha
Copy link
Contributor

pikonha commented Nov 5, 2024

Feature Request

The registering of a subdomain shouldn't be enforced by the standard to be paid in ETH because this makes the implementation too strict. We should instead support ERC-20 payments when applicable or ETH as established by the EIP-7528.

Describe Preferred Solution

RegisterParams should return an ERC-20 contract address when applicable or 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee when ETH is the token used on payments as described by the EIP-7528.

Architecture Diagram

QA Replication steps

  1. call registerParams
  2. receive an ERC-20 contract address and use it to pay for the subdomain registering
@pikonha pikonha added the enhancement New feature or request label Nov 5, 2024
@pikonha pikonha added this to the Layer 2 implementation milestone Nov 5, 2024
@pikonha pikonha self-assigned this Nov 5, 2024
@pikonha pikonha moved this to 💡 Ideas in ENS Nov 5, 2024
@pikonha pikonha added this to ENS Nov 5, 2024
@pikonha pikonha changed the title RegisterParams supporting EIP-7528 RegisterParams return ERC-20 token address for payment Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ⛰️ Backlog
Development

No branches or pull requests

1 participant