Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L2] RegisterParams improvement #238

Open
pikonha opened this issue Nov 7, 2024 · 0 comments
Open

[L2] RegisterParams improvement #238

pikonha opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pikonha
Copy link
Contributor

pikonha commented Nov 7, 2024

Feature Request

The registerParams struct can be more complete by adding the following properties making it easier for the frontend to integrate with it.

Describe Preferred Solution

  • available: whether the domains is available for registering
  • token: EIP-7528 token address enabling ERC-20 payments.

The final struct would look like the following:

struct RegisterParams {
    uint256 price;
    bool available;
    address token;
    uint256 commitTime;
    bytes extraData;
}

QA Replication steps

  1. call registerParams
  2. receive an available and token properties
@pikonha pikonha added this to ENS Oct 21, 2024
@pikonha pikonha self-assigned this Nov 7, 2024
@pikonha pikonha converted this from a draft issue Nov 7, 2024
@pikonha pikonha added the enhancement New feature or request label Nov 7, 2024
@pikonha pikonha added this to the Layer 2 implementation milestone Nov 7, 2024
@pikonha pikonha changed the title offchain subdomain isAvailable L2: offchain subdomain isAvailable Nov 7, 2024
@pikonha pikonha moved this from 🔖 TODO to ⛰️ Backlog in ENS Nov 29, 2024
@pikonha pikonha moved this from ⛰️ Backlog to 🔖 TODO in ENS Dec 17, 2024
@pikonha pikonha changed the title L2: offchain subdomain isAvailable [L2] RegisterParams improvement Dec 17, 2024
@pikonha pikonha moved this from 🔖 TODO to 🛠️ In Progress in ENS Dec 17, 2024
@pikonha pikonha moved this from 🛠️ In Progress to 🕵️‍♀️ In Review in ENS Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🕵️‍♀️ In Review
Development

No branches or pull requests

1 participant