Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution result cache revamp #172

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Execution result cache revamp #172

merged 4 commits into from
Oct 29, 2024

Conversation

Maelkum
Copy link
Collaborator

@Maelkum Maelkum commented Oct 10, 2024

  • using a LRU cache instead of keeping execution results in memory indefinitely
  • keeping 1000 execution results in cache, after that older results get pushed out
  • use generics for our waitmap implementation - enforce strict types
  • tidy up Go types to be uniform when using the cache - before we had a soup of types because we were putting/pulling things in a map[string]any
  • refactored execution result types - moved the execution signature closer to the output of the execution (alongside metadata)

@Maelkum Maelkum self-assigned this Oct 10, 2024
@dmikey
Copy link
Contributor

dmikey commented Oct 29, 2024

I like that we're tossing aside the generic. This is great work.

@dmikey dmikey merged commit 86fd1f6 into main Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikey dmikey dmikey approved these changes

Assignees

@Maelkum Maelkum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maelkum @dmikey