Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISeeds - Menu Component #3335

Closed
emilyjablonski opened this issue Feb 17, 2023 · 8 comments
Closed

UISeeds - Menu Component #3335

emilyjablonski opened this issue Feb 17, 2023 · 8 comments
Assignees
Labels
validated Legitimate bug or issue

Comments

@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Feb 17, 2023

Description

Transfer the SideNav component from UIC to UISeeds.

Links

Eng Audit
[Zero height Docs]((https://www.notion.so/exygy/Side-Nav-8adbd9e86bc34400aaf526f08245cd9f?pvs=4)

Additional Details

Acceptance Criteria

Figma

QA review/instructions

@emilyjablonski emilyjablonski added the blocked Further development is blocked waiting for something external to this ticket label Feb 17, 2023
@slowbot slowbot changed the title UISeeds - SideNav Component UISeeds - Menu Component Mar 17, 2023
@slowbot slowbot assigned emilyjablonski and jaredcwhite and unassigned slowbot Apr 12, 2023
@emilyjablonski
Copy link
Collaborator Author

  • The content on best practices is duplicated as a heads up!
  • When not to use: “When you have only a few navigation options that can fit in a header or top navigation.”
    • I think I need more guidance on what a few is, is it 2 / 6 / 12?
  • "Active navigation items should be clearly indicated and remain visible even when the navigation is collapsed.”
    • What is the visual state for remaining visible when collapsed?
  • I think eventually I would love additional context and guidance in the variants about when to use each variant - that is something I’m clear on and will need to be defined on uptake
  • How do we handle the nested levels on the horizontal and dropdown versions?

@slowbot
Copy link
Collaborator

slowbot commented Apr 18, 2023

  • "When you have only 1 or 2 navigation options that can fit in a header or top navigation"
  • Revisit if relevant
  • Makes sense and adds context
  • Document horizontal display of nested items

@emilyjablonski
Copy link
Collaborator Author

emilyjablonski commented Apr 25, 2023

Thank you!

A remaining question I have about the last row is why the vertical version on smaller screens defaults to menu, vs just letting consumers decide if they want menu. I'm not sure having that breakpoint is the best path.

I'm also not seeing the notes from your 4th bullet point of documenting horizontal display of nested items, lmk if I'm missing that somewhere!

@slowbot

@slowbot
Copy link
Collaborator

slowbot commented Apr 25, 2023

  • Breakout dropdown as its own component and remove as a dependency

bloom-housing/ui-seeds#29

@slowbot slowbot removed the blocked Further development is blocked waiting for something external to this ticket label Apr 26, 2023
@slowbot
Copy link
Collaborator

slowbot commented Apr 26, 2023

@emilyjablonski @jaredcwhite added story details and removed blocked tag

@slowbot slowbot added the validated Legitimate bug or issue label May 31, 2023
@jaredcwhite
Copy link
Collaborator

Closed in favor of an updated issue in the Seeds repo: bloom-housing/ui-seeds#77

@jaredcwhite jaredcwhite closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated Legitimate bug or issue
Projects
None yet
Development

No branches or pull requests

3 participants