From c3585fb659882f03df0059936db824c8c10aedd7 Mon Sep 17 00:00:00 2001
From: Akshat Sikarwar <akshat.sikarwar@gmail.com>
Date: Mon, 18 Nov 2024 10:49:55 +0530
Subject: [PATCH] Remove unused parameter

Signed-off-by: Akshat Sikarwar <asikarwar1@bloomberg.net>
---
 db/comdb2.h       |  2 +-
 db/fdb_bend_sql.c |  2 +-
 db/sql.h          |  2 +-
 db/sqlglue.c      | 10 +++++-----
 lua/sp.c          |  2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/db/comdb2.h b/db/comdb2.h
index 3380d26b31..f7e8279df3 100644
--- a/db/comdb2.h
+++ b/db/comdb2.h
@@ -2920,7 +2920,7 @@ enum {
 
 struct sql_thread *start_sql_thread(void);
 struct sqlclntstate;
-int initialize_shadow_trans(struct sqlclntstate *, struct sql_thread *thd);
+int initialize_shadow_trans(struct sqlclntstate *);
 void get_current_lsn(struct sqlclntstate *clnt);
 void done_sql_thread(void);
 int sql_debug_logf(struct sqlclntstate *clnt, const char *func, int line,
diff --git a/db/fdb_bend_sql.c b/db/fdb_bend_sql.c
index 48842e0bee..14fc7ceb6d 100644
--- a/db/fdb_bend_sql.c
+++ b/db/fdb_bend_sql.c
@@ -357,7 +357,7 @@ int fdb_svc_trans_begin(char *tid, enum transaction_level lvl, int flags, int se
                 __func__, us);
     }
 
-    if ((rc = initialize_shadow_trans(clnt, thd)) != 0)
+    if ((rc = initialize_shadow_trans(clnt)) != 0)
         return rc;
 
     if (clnt->dbtran.mode == TRANLEVEL_SOSQL && !clnt->osql.sock_started)
diff --git a/db/sql.h b/db/sql.h
index d49bf86b9a..28dac2d4b7 100644
--- a/db/sql.h
+++ b/db/sql.h
@@ -1609,7 +1609,7 @@ int fdb_access_control_create(struct sqlclntstate *, char *str);
 int disable_server_sql_timeouts(void);
 int osql_clean_sqlclntstate(struct sqlclntstate *);
 void handle_failed_dispatch(struct sqlclntstate *, char *err);
-int start_new_transaction(struct sqlclntstate *, struct sql_thread *);
+int start_new_transaction(struct sqlclntstate *);
 int sqlite3LockStmtTablesRecover(sqlite3_stmt *);
 
 struct sql_col_info {
diff --git a/db/sqlglue.c b/db/sqlglue.c
index 89e44e18b1..3979ecebd6 100644
--- a/db/sqlglue.c
+++ b/db/sqlglue.c
@@ -4683,7 +4683,7 @@ int get_snapshot(struct sqlclntstate *clnt, int *f, int *o)
     return clnt->plugin.get_snapshot(clnt, f, o);
 }
 
-int initialize_shadow_trans(struct sqlclntstate *clnt, struct sql_thread *thd)
+int initialize_shadow_trans(struct sqlclntstate *clnt)
 {
     int rc = SQLITE_OK;
     struct ireq iq;
@@ -4801,7 +4801,7 @@ int initialize_shadow_trans(struct sqlclntstate *clnt, struct sql_thread *thd)
     return rc;
 }
 
-int start_new_transaction(struct sqlclntstate *clnt, struct sql_thread *thd)
+int start_new_transaction(struct sqlclntstate *clnt)
 {
     int rc;
 
@@ -4847,7 +4847,7 @@ int start_new_transaction(struct sqlclntstate *clnt, struct sql_thread *thd)
                pthread_self(), clnt->dbtran.mode, clnt->intrans);
     }
 #endif
-    if ((rc = initialize_shadow_trans(clnt, thd)) != 0) {
+    if ((rc = initialize_shadow_trans(clnt)) != 0) {
         sql_debug_logf(clnt, __func__, __LINE__,
                        "initialize_shadow_tran returns %d\n", rc);
         return rc;
@@ -4990,7 +4990,7 @@ int sqlite3BtreeBeginTrans(Vdbe *vdbe, Btree *pBt, int wrflag, int *pSchemaVersi
         clnt->dbtran.mode = TRANLEVEL_RECOM;
     }
 
-    rc = start_new_transaction(clnt, thd);
+    rc = start_new_transaction(clnt);
 
     /* 2pc on tunable, only here for now */
     extern int gbl_2pc;
@@ -8840,7 +8840,7 @@ static int chunk_transaction(BtCursor *pCur, struct sqlclntstate *clnt,
             goto done;
         }
 
-        rc = start_new_transaction(clnt, thd);
+        rc = start_new_transaction(clnt);
 
         if (thd->bt) {
             LISTC_FOR_EACH(&thd->bt->cursors, cur, lnk)
diff --git a/lua/sp.c b/lua/sp.c
index 2b89f543a6..a90090ef62 100644
--- a/lua/sp.c
+++ b/lua/sp.c
@@ -889,7 +889,7 @@ static int dbconsumer_consume(Lua L)
         }
     }
     if (!clnt->intrans) {
-        if ((rc = start_new_transaction(clnt, clnt->thd->sqlthd)) != 0) {
+        if ((rc = start_new_transaction(clnt)) != 0) {
             luaL_error(L, "%s: start_new_transaction intrans:%d err:%s rc:%d\n",
                        __func__, clnt->intrans, err, rc);
         }