Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

Incorrect call to authClient.accessToken() #7

Open
gabmontes opened this issue May 8, 2019 · 2 comments
Open

Incorrect call to authClient.accessToken() #7

gabmontes opened this issue May 8, 2019 · 2 comments

Comments

@gabmontes
Copy link
Member

The call to authClient.accessToken() expects to params and returns a promise:

client.accessToken = function () {

Actual code sends a callback:

authClient.accessToken(function (token) {

@ndelvalle
Copy link
Contributor

ndelvalle commented May 9, 2019

Yes @gabmontes you are right. Socket.io is not yet fully implemented in this SDK. I want to have the same regular socket.io client API but using the cloud auth under the hood and make it transparent to the user. I will consider this when I finish the implementation.

@gabmontes
Copy link
Member Author

If it is not fully implemented, a cleaner option is to have it in a branch and avoid even mentioning in the documentation or exposing it in the API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants