-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(default-flatpaks): Module does not add flathub remote when not explicitly specified #166
Comments
I wonder if manually adding flathub remote to recipe fixes this error. Sudo errors are for notify-send, which can't function on login screen (gdm), so that's normal. |
How would I manually add flathub remote to the recipe? |
You would add remote like this in recipe: repo-url: https://dl.flathub.org/repo/flathub.flatpakrepo
repo-name: flathub |
And this would add it as a system remote, yes? |
You add it in |
Also add |
Added that into the image now. First without the repo-title, then with. (though it shouldn't change things as far as i'm aware). Now (after each of those) the output of (ie, this)
Nevertheless, |
Not seeing the notifications either btw |
Oh, I know what is the issue. yq was not copied to the system on Build Action on 1.1.0 & below. Please update Build Action yml to latest 1.2.0 & issue will be solved. |
okay. (makes sense theres an error about yq). How would I do that? |
Okay so its in .github/workflows/build.yml (I'm still new to this). Should dependabot keep that up to date? |
It should. If dependabot somehow didn't notify you of the new release, go to repo Insights, Dependency graph, Dependabot, Recent update jobs & check the status of what happened there. That's correct way to manually edit. |
Had already bumped the version number by editing the file, but I'll give that a look and do that next time |
Also, with that change, it still doesn't seem to work properly. On reboot the service might not have run? I didn't see a notification. Ran it manually with systemctl and it showed the notification as if it ran and completed successfully but no flatpaks are installed |
Dependabot wasn't enabled, now it is. should work in the future. thanks! |
I'll try in a bit adding another default to see if it installs on my main system, as well as reinstall from iso with the new image and see what each of those do |
After some testing and typo fixing, it now works when I run it manually. (with |
That's possible. I never used VPN, so I didn't test how the module behaves with it. It also depends on how VPN is implemented.
Do you mean the check of flatpak names in the list? If so, you can just do
which will output the list of flatpaks you inputted. Location of that list is present in the docs. You can also see the content of the flatpak list in build-time logs before looking inside the flatpak list on booted system. |
Automatically checking whether the Flatpak ID exists in the repo would require interfacing with the repository, not sure if that would be hard... |
If he means the verification of flatpak IDs themself, there was a talk about this a while back in Discord about having this integrated in the build-time, since Bluefin had the mistake in pre-installing Pods due to wrong ID, which caused constant retry of the service & unnecessary CPU usage. However, it can happen that flathub repo could be down for maintenance reasons sometimes, so builds would falsely fail. If he means on simplifying flatpak list to use direct names instead of IDs, I'm afraid that wouldn't be possible without making a mess. Although, this is a separate topic not related to this issue. |
Yea I think this is the issue, from further testing. Otherwise it seems it works now |
I'm noting that it seems easy to make a typo in the id of the flatpak and somewhat harder to notice that was the error, making troubleshooting perhaps more difficult. And as you said it's a separate topic, just something I noticed troubleshooting for this issue |
Thanks for the reminder of that issue anyway, I will open it separately. |
So to fix one could just not have a vpn autostart, or maybe default-flatpaks could start on a longer delay or retry in a minute or two if it fails |
Maybe systemd service unit could be optimized a bit better in some areas. If you can test how the default-flatpaks module behaves with different unit settings, it would be good to know the feedback & if there is a potential fix for your VPN scenario. |
Sure I could do that. Might be a while between tests as I'm somewhat busy but i'd love to help improve the project if I can |
Still being very unreliable with additional testing, even running manually. However, I have run into what seems to be an additional issue. When I add a second instance of the default-flatpaks module, in order to add a second repo (gnome-nightly specifically), that takes precedence over the previous instance and no longer adds flathub or any of the packages to the install list. |
Okay, looking at the systemd unit file now. It says |
This is a known issue, where
Failure is usually triggered when repo instance is down or because of some local network issue. |
Before refactoring the module, we need to form bash module code guidelines, where all modules would be refactored to conform those. So that would be a chance to address some existing issues like yours & possibly add some better functionality to the modules. |
It seems like it might not be doing this quite right. I'll look at it further sometime soon. Otherwise it seems like everything should be fixable with a refactor when that comes about. 👍🏼 |
Should this be updated in the docs then? As currently the docs imply that multiple repos work |
I updated it as soon as you mentioned it, it's available on website now. https://blue-build.org/reference/modules/default-flatpaks/#known-issues |
I'll close this issue, because it's very fragmented & it seems that the main problem report of this issue is network connection issue (while previously, it was a combination of both problems, I got the network connection problems also in 1 PC, so I recommend to watch and/or discuss further in the issue #346 instead, which I created. |
I run a custom image, (https://github.com/Oakleafknight06/startingleaf), installed on two systems, my main desktop and a second test "desktop" intel nuc.
On the main pc, default-flatpaks works correctly. On the second one, with the current install (from iso made from ublueos/isogenerator) it doesnt seem to have run at all, and on the previous install showed the notification but didnt seem to do anything.
The previous install was from fedora silverblue iso, and a rebase to my own image.
On both that install and this current one, I found flathub (nor any other flatpak remote) seem to be enabled by default. On the first time installing I manually added flathub, on the second install I have not.
This is the output of
systemctl status system-flatpak-setup
on my main pcversus on the second pc
The text was updated successfully, but these errors were encountered: