New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropTypes generated by Object.keys are wrapped with double quotes #132

Open

JamesPlayer opened this issue Dec 19, 2017 · 0 comments

JamesPlayer commented Dec 19, 2017

If I have a component that has a PropType of oneOf, the array is generated using Object.keys ie:

const icons = {
  trash: '...',
  tag: '...',
  tagMerge: '...',
  ...
};

Icon.propTypes = {
  icon: PropTypes.oneOf(Object.keys(icons)),
  ...
};

In BlueKit each icon in the enum dropdown is wrapped with double quotes, which stops the preview from working:

I can see in the componentsIndex.js that it's been generated with the quotes:

propsDefinition: {icon:{type:{name:"enum",value:[{value:"\"trash\"",computed:false},{value:"\"tag\"",computed:false},{value:"\"tagMerge\"",computed:false} ...

Please look into it, thanks!

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment