From a1968c452e4213a0eebd7db8aab0004293c6f3fb Mon Sep 17 00:00:00 2001
From: Taylor <tbmcdonald31@gmail.com>
Date: Wed, 12 Jul 2017 13:44:24 -0700
Subject: [PATCH] async prop set directly vs via Element.setAttribute

---
 README.md          | 2 +-
 src/index.jsx      | 5 +++--
 src/index.test.jsx | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 9a1e261..753df5b 100644
--- a/README.md
+++ b/README.md
@@ -25,7 +25,7 @@ Called when the requested script is fully loaded.
 URL pointing to the script you want to load.
 
 ### `attributes`
-An object used to define custom attributes to be set on the script element. For example, `attributes={{ id: 'someId', 'data-custom: 'value' }}` will result in `<script id="someId" data-custom="value" />`
+An object used to define custom attributes to be set on the script element. For example, `attributes={{ id: 'someId', 'data-custom: 'value' }}` will result in `<script id="someId" data-custom="value" />`. To set `async=false`, specify in `attributes` like so: `attributes={{ async: 'false', ... }}`. 
 
 ## Example
 You can use the following code to load jQuery in your app:
diff --git a/src/index.jsx b/src/index.jsx
index c9df148..3b40687 100644
--- a/src/index.jsx
+++ b/src/index.jsx
@@ -90,8 +90,9 @@ export default class Script extends React.Component {
 
     script.src = url;
     
-    // default async to true if not set with custom attributes
-    if (!script.hasAttribute('async')) {
+    if (script.hasAttribute('async') && script.getAttribute('async') === 'false') {
+      script.async = false;
+    } else {
       script.async = 1;
     }
 
diff --git a/src/index.test.jsx b/src/index.test.jsx
index 1b6e3c4..deff642 100644
--- a/src/index.test.jsx
+++ b/src/index.test.jsx
@@ -17,7 +17,7 @@ beforeEach(() => {
       id: 'dummyId',
       dummy: 'non standard',
       'data-dummy': 'standard',
-      async: false,
+      async: 'false',
     },
   };
   wrapper = shallow(<Script {...props} />);