Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the top safe area inset on profile #6881

Closed

Conversation

adelbeke
Copy link

@adelbeke adelbeke commented Dec 1, 2024

Taking inspiration from this post from Sam, this PR removes the top safe area blank on profile.

  • Disabling the blank space by setting the disableTopPadding on Layout.Screen
  • Updating lot of style to add the topInset value on height or top position
  • Updating some values into useAnimatedStyle, instead of repeating the 150 - topInset value I created a constant
  • Updating the loading component
  • The topInset prop has been added to handle the case on the edit modal where we don't want to handler the top inset

Wondering how we can handle the status bar color properly, before the status bar was always black over the blank space content. Now it should adapt the status bar's color according to the user banner but I don't really know how to handle this point.

This is my first open source contribution, please do feel free to tell me if something is wrong on the process/communication.
Greeting 🫶

Preview

iOS
https://github.com/user-attachments/assets/5b95064f-4183-49ce-9d37-da04fff0a73a

Android
https://github.com/user-attachments/assets/ac2e0692-934f-4557-b1f5-19fb2bc66777

@adelbeke adelbeke changed the title feat: remove the top safe area inset on profile Remove the top safe area inset on profile Dec 5, 2024
@adelbeke
Copy link
Author

adelbeke commented Dec 7, 2024

handled by core team
#6967

@adelbeke adelbeke closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant