Remove the top safe area inset on profile #6881
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking inspiration from this post from Sam, this PR removes the top safe area blank on profile.
disableTopPadding
onLayout.Screen
topInset
value onheight
ortop
positionuseAnimatedStyle
, instead of repeating the150 - topInset
value I created a constanttopInset
prop has been added to handle the case on the edit modal where we don't want to handler the top insetWondering how we can handle the status bar color properly, before the status bar was always black over the blank space content. Now it should adapt the status bar's color according to the user banner but I don't really know how to handle this point.
This is my first open source contribution, please do feel free to tell me if something is wrong on the process/communication.
Greeting 🫶
Preview
iOS
https://github.com/user-attachments/assets/5b95064f-4183-49ce-9d37-da04fff0a73a
Android
https://github.com/user-attachments/assets/ac2e0692-934f-4557-b1f5-19fb2bc66777