Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name can contain non-ascii letters or space and long names must fit in the user context menu #1561

Open
gorkem-bwl opened this issue Jan 14, 2025 · 6 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Jan 14, 2025

This check should be fixed so that name can contain space or diactric letters (e.g ç, ö, ğ).

Examples:

image

image

Also if a name is long, it must fit the user context menu by truncating:

image
@gorkem-bwl gorkem-bwl added the good first issue Good for newcomers label Jan 14, 2025
@gorkem-bwl gorkem-bwl added this to the 2.0.1 milestone Jan 14, 2025
@gorkem-bwl gorkem-bwl changed the title Name can contain non-ascii letters or space Name can contain non-ascii letters or space and long names must fit in the user context menu Jan 14, 2025
@yoyounik
Copy link

Hey @gorkem-bwl
can i be assigned to work on this ?

@gorkem-bwl
Copy link
Contributor Author

@yoyounik thanks for your interest in the project :)

Please go ahead!

@yoyounik
Copy link

@gorkem-bwl, i have made some changes in the PR : #1570
Do let me know if any changes are required.

@gorkem-bwl
Copy link
Contributor Author

@yoyounik please read thoroughly and make sure you check those items as you send the PR:

image

@yoyounik
Copy link

Yes @gorkem-bwl thanks for pointing it out :)

@gorkem-bwl
Copy link
Contributor Author

@yoyounik I have added my comments there. Basically, you need a self review / testing of your code before sending a PR, together with a screenshot / video of how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants