Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor, page speed and infrastructure width #1252

Open
marcelluscaio opened this issue Dec 2, 2024 · 7 comments
Open

Monitor, page speed and infrastructure width #1252

marcelluscaio opened this issue Dec 2, 2024 · 7 comments
Labels
design Design related
Milestone

Comments

@marcelluscaio
Copy link
Contributor

I believe we should apply { width: "100%", gap: "1rem" } to all three main pages, so our aside will have exactly the size needed and no more, bringing better use of screen area

@gorkem-bwl
Copy link
Contributor

@peterpardo do you want to work on this?

@peterpardo
Copy link
Contributor

@peterpardo do you want to work on this?

Yeah, sure! I'll knock this one out.

@peterpardo
Copy link
Contributor

I believe we should apply { width: "100%", gap: "1rem" } to all three main pages, so our aside will have exactly the size needed and no more, bringing better use of screen area

Hello! The three remaining pages you were referring to are the Monitors, Pagespeed, and the Infrastructure pages?

@gorkem-bwl
Copy link
Contributor

I believe we should apply { width: "100%", gap: "1rem" } to all three main pages, so our aside will have exactly the size needed and no more, bringing better use of screen area

Hello! The three remaining pages you were referring to are the Monitors, Pagespeed, and the Infrastructure pages?

Yep! Those are the main 'features' of Checkmate.

@marcelluscaio are you talking about only those 3 pages, or all the sidebar pages (Incidents, Maintenance, Account, Other) should be included in this as well?

@marcelluscaio
Copy link
Contributor Author

Yes, those 3 were the ones I had in mind when creating the Issue, but maybe we should discuss this to be sure of what we want before assigning that to someone

@gorkem-bwl
Copy link
Contributor

Yes, those 3 were the ones I had in mind when creating the Issue, but maybe we should discuss this to be sure of what we want before assigning that to someone

Sure. What was in your mind exactly? Just asking since there are more sidebar entries than those 3 links.

@gorkem-bwl gorkem-bwl added the design Design related label Dec 5, 2024
@gorkem-bwl gorkem-bwl modified the milestones: 2.1, 2.0.1 Dec 5, 2024
@gorkem-bwl
Copy link
Contributor

@marcelluscaio ping here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related
Projects
None yet
Development

No branches or pull requests

3 participants