-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match the Infrastructure details page design with Figma design #1291
Comments
I would like to work on it |
Yep, go ahead @pratikshelar546 - make sure you share your final design before opening a PR for this. In case of doubt (e.g use of colors, fonts, components etc) please ask. |
@gorkem-bwl sure started the work |
is there any way to get dummy data i tried every possible way to get data and reach to this page but failed |
You need to run the agent on a server to receive server side infrastructure data. I have necessary credentials and a secret for this. Please send an email to [email protected] so you can enter this information, and get real data from a server. |
hello @ajhollid i am facing some issues to fix this issue. I'm not able to reach this page can you please help me into it and doing setup |
@pratikshelar546 can you write here what you did, step by step, what the output was, and where you are stuck? This is important to make sure Alex can pinpoint your problem. |
Hi @pratikshelar546 , As @gorkem-bwl mentioned you need to run the Capture agent on the target that you want to monitor. The easiest way to do this is just run the Capture agent on your local machine and point a monitor to The other options is to use our test server, you can reach out to the email address @gorkem-bwl provided above for credentials. |
Yep, I just provided @pratikshelar546 the credentials for our server so he can test it. @pratikshelar546 let me know if you are successful in connecting. |
Hi @gorkem-bwl and @ajhollid, Thank you both for your help! @ajhollid, if you’re available and comfortable, could we connect on Slack to discuss the setup? Apologies for taking up so much of your time with this! |
Hi @pratikshelar546 , Walking you through the set up is beyond the scope of what I can help with, but if you have a specific issue with the setup that is causing a problem you can post it here and I can take a look. The developer setup documentation is quite thorough and should provide all the information you need to get running. |
Hi @ajhollid, I followed all the steps mentioned in the document, and the app is running successfully. However, I encountered an issue: I created an infrastructure to reach its details page, but the infrastructure's status remains pending. Since it’s not fully up, I am unable to access its details page. Additionally, I noticed a mention about running the Capture agent on the target infrastructure that I want to monitor. Could you please confirm if this is a required step? If so, could you provide additional guidance on how to set it up? Lastly, I received a URL from @gorkem-bwl. Could you clarify where exactly I need to use that URL in this process? I have already followed the steps mentioned in the Capture repository. Thank you for your assistance! |
I'll leave the "pending" issue to Alex.
In fact, you should already have done this from what I read in your message above. When you go to Infrastructure from the sidebar, you'll see nothing has been added yet. When you add the URL I gave you together with the secret, you should see the data flowing in from that server. You don't need to deploy Capture on another server/Linux docker instance. HTH. |
@gorkem-bwl Thank you for the clarification! The issue is now resolved, and I can see the data flowing in as expected. I can now focus on fixing the UI. Thanks again for your help! |
Yep! That's it! |
Hi @gorkem-bwl, I've updated the design. Could you please take a look and let me know if there are any changes that could further improve the UI? |
Can you please also send the light theme? The dark theme is difficult to get an understanding of the UI details. Is there an issue connecting to the server? It seems like the dashboard doesn't get data. |
I am sorry - it should be http://64.23.145.13:5001/api/v1/metrics (please add /metrics at the end). |
Can you double check the Figma file again, as there are subtle background colors in "Used" / "Total" numbers? |
Sure I will do necessary changes and if I need help regarding font and colors I'll reach out here |
hi @gorkem-bwl I have made the changes you suggested. |
Looks good! Thanks. Please send a PR. |
I'd like to extend my gratitude to @gorkem-bwl and @ajhollid for their support. I'm excited to submit my first pull request to Checkmate and look forward to contributing more in the future. asking one noob question i have to take pull from develop branch before creating pull request? |
Should be it. A core team member will respond if that's not the case. |
@pratikshelar546 confirmed that you need to pull from develop branch. |
@gorkem-bwl Thank you for confirming. I have already taken a pull from the develop branch, there is no conflicts, pushed my changes, and successfully raised a PR. Please let me know if there's anything else required. |
Currently there are a few missing decorations in the Infrastructure design page.
Here is the Infra details page:
This is the Figma design page:
You need to fix fonts and add subtle background elements to the gauge elements.
Charts look fine, no need to touch them.
The text was updated successfully, but these errors were encountered: