Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filler Page is shown while we wait for fetching banners/popups in default page #207

Closed
erenfn opened this issue Sep 14, 2024 · 0 comments · Fixed by #209
Closed

Filler Page is shown while we wait for fetching banners/popups in default page #207

erenfn opened this issue Sep 14, 2024 · 0 comments · Fixed by #209
Assignees
Labels
enhancement New feature or request

Comments

@erenfn
Copy link
Collaborator

erenfn commented Sep 14, 2024

It takes time to fetch items, and {items.length === 0} returns 0 at initialization, causing the filler page to display momentarily. On option is to store that information in Redux so we don't have to wait for the backend and can display the correct page immediately. Or we can do someting with useMemo

@erenfn erenfn added the enhancement New feature or request label Sep 14, 2024
@erenfn erenfn self-assigned this Sep 14, 2024
@erenfn erenfn changed the title Use redux to store items.length in DefultPageTemplate to smoothen flow Filler Page is shown while we wait for fetching banners/popups in default page Sep 14, 2024
@erenfn erenfn linked a pull request Sep 14, 2024 that will close this issue
@erenfn erenfn closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant