No populate on request by default

[mkrajewski90]

@bluszcz - I have an issue here to resolve (I send it in my next PR) but I back to this PR I think we should no populate by default. I see some proper reasons not to do it:

1. If Strapi decided not to populate fields by default it means that's their way, so a user should declare populate for a collection.
2. Populate might be with different types and if it's not default option it's better to give user decisions about populate type (to discuss)
3. I work on get_data improvement for some collection and I need to add populate option to the method. It doesn't make sense to do populate request for all collections, so this is next reason not to populate by default

My solution

Instead of

def get_document(did)
  uri_document = URI("#{@site.endpoint}/api/#{endpoint}/#{did}?populate=#{populate}")
end

we can have

def get_document(did)
  uri_document = URI("#{@site.endpoint}/api/#{endpoint}/#{did}?#{populate}")
end

with populate method:

def populate
  "populate=#{@config["populate"]}" if @config["populate"]
end

Please let me know what do you think about this.

[mkrajewski90]

Another question is maybe we should in get_data request store this populate.

So we have two types of requests:

• collection request (get_data method)
• resource request (get_document method)

We don't use populate in collection (but we might), but we can just add populate to parameters and it works. But here we must duplicate this in the config (populate for collection, populate for resource) and it might be confusing.

This is an open question to discuss how we should treat populate parameter.

[mkrajewski90]

Related PR: #27

[bluszcz]

I think giving option to populate or not is a good idea, also it is good idea to keep the defaults on bare minimum. I will look into it, tests and will provide more feedback. Potentially can be included into next release.

[mkrajewski90]

I think about parametrs for a collection and a resource but this might be overwhelming.

In that case populate goes to parameters.

[bluszcz]

@mkrajewski90 does your PR resolve this issue fully?