Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnt (Do Not Track) option for Vimeo #5

Open
adrianbj opened this issue Jun 7, 2022 · 7 comments
Open

dnt (Do Not Track) option for Vimeo #5

adrianbj opened this issue Jun 7, 2022 · 7 comments

Comments

@adrianbj
Copy link

adrianbj commented Jun 7, 2022

Hi @blynx - would you please add a dnt option for Vimeo?

More info: https://www.thomasvantuycom.com/privacy-friendly-video-embeds/

Thanks.

@adrianbj adrianbj changed the title dnt option for Vimeo dnt (Do Not Track) option for Vimeo Jun 7, 2022
@netcarver
Copy link

@blynx Hi Steffen, This would be a nice feature to have.

@blynx
Copy link
Owner

blynx commented Jun 8, 2022

Hi!
indeed - ugh, and I just woke up from a overly long processwire sleep.

I created this PR: #6, but I just edited it quickly here in github. Could you have a look and see if it works for you? I try to get my hands back on an processwire instance to check that out soon I hope.

(I think this should just make the option available in the module settings - maybe there are more new options to adapt actually ...!?)

Also, looking at https://stackoverflow.com/questions/63173525/vimeo-embed-do-not-track and following the concers to https://stackoverflow.com/questions/44837450/recommended-method-to-prevent-any-content-inside-iframe-from-setting-cookies there could be implemented some fancier control.

@blynx
Copy link
Owner

blynx commented Jun 8, 2022

Oh and btw, does anyone of you want to help maintain this module (and maybe another one ... !?) Since I'm not having my hands on processwire right now and probably wont have any time soon.
(Will get back into the forums later, too, to see how to hand over things)

@netcarver
Copy link

@blynx Hi Steffen, thanks for waking up for this :) Will try out your changes later this afternoon.

Do you have a roadmap or other changes in mind for this module?

@blynx
Copy link
Owner

blynx commented Jun 8, 2022

Not really, I just thought there might be other new properties like dnt which could be added. So I/we could have just a look at the vimeo/youtube docs again and see whats new and could be added here.
I mean this module does have a quite narrow 'feature space'(!?) ... so I think the most changes would be some refinements every now and then.

@adrianbj
Copy link
Author

@blynx - I found that it didn't work for me with the default "true" but if I changed it to 1 then it worked as expected. Do you know of any reason not to go with 1?

@blynx
Copy link
Owner

blynx commented Jun 15, 2022

ah mh, seemed ok from the vimeo docs. I just changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants