Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for spoilers in text commands #87

Open
dy-lin opened this issue Jul 29, 2023 · 3 comments
Open

Add support for spoilers in text commands #87

dy-lin opened this issue Jul 29, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dy-lin
Copy link

dy-lin commented Jul 29, 2023

I'd like support for spoilers when using text commands just as is available with slash commands.

By updating the prefix to include the two pipes, the bot still recognizes the instagram link.

 "Prefix": [ "https://www.instagram.com/", "https://instagram.com/", "http://www.instagram.com/", "http://instagram.com/", "||https://instagram.com/", "|| https://instagram.com/"  ]

The bot could register that the prefix contains pipes and use the isSpoiler parameter in FileAttachment (like with the slash commands).

It appears the infrastructure is already present, and just needs to detect whether the text command or prefix contains pipes and adjust accordingly.

@bman46
Copy link
Owner

bman46 commented Jul 29, 2023

It's certainly feasible to do. What is your use case for this though? I would think that it would be easier and more user friendly to use the slash command to do this.

@bman46 bman46 added enhancement New feature or request good first issue Good for newcomers labels Jul 29, 2023
@dy-lin
Copy link
Author

dy-lin commented Jul 31, 2023

I mostly use Discord on mobile and find slash commands clunky to use since you have to select each parameter.

@bman46
Copy link
Owner

bman46 commented Aug 1, 2023

Ok, makes sense. For now, I am prioritizing #85 but after that I should be able to get around to it as the changes required should not be too complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants