Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to react-charts? #26

Closed
16 of 18 tasks
bmaupin opened this issue Dec 3, 2021 · 2 comments
Closed
16 of 18 tasks

Migrate to react-charts? #26

bmaupin opened this issue Dec 3, 2021 · 2 comments
Assignees

Comments

@bmaupin
Copy link
Owner

bmaupin commented Dec 3, 2021

Since react-vis is deprecated for a long time, react-charts looks very promising. It should also let us fix #23.

  • Needed
    • Override curve with custom D3 sigmoid curve
      • y axes curve option
    • Don't show null values
      • return null in y axis getValue
    • Override axis labels
      • y axis options > formatters > scale
    • Override line colours
      • chart options > getSeriesStyle
      • or defaultColors?
    • Left/right axes
      • return a second axis in secondaryAxes with position: 'right'
    • Set number of ticks
      • y axis options > tickCount
    • Override datum style (see Override datum style when not hovered TanStack/react-charts#264)
    • Disable animations
      • return transition: 'none' in getSeriesStyle
    • Override line style on hover
    • Override popover table
      • axis options > formatters > tooltip?
    • Don't show horizontal/vertical lines on popover
    • Fix hover on border values not always working
    • Fix console errors
    • Darken x/y axis labels
      • They're not as bad as react-vis, so we'll leave the defaults for now
    • Better use of vertical/horizontal height (UI improvements #11)
    • Optimize mobile view
  • Optional
    • Invert axis
      • y axis options > invert: true
    • Fix for chart margins changing when browser window is resized
@bmaupin bmaupin self-assigned this Dec 14, 2021
@bmaupin
Copy link
Owner Author

bmaupin commented Dec 14, 2021

The branch for this work is https://github.com/bmaupin/langtrends/tree/migrate-to-react-charts

@bmaupin
Copy link
Owner Author

bmaupin commented Jan 5, 2022

Alternatives:

I think at this point react-charts is probably the best option since we've almost worked out all the bugs.

@bmaupin bmaupin closed this as completed in 78a51dd Jan 7, 2022
bmaupin added a commit that referenced this issue Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant