Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx 2.1.2 breaks our github plugin #60

Open
tkell opened this issue Jul 28, 2019 · 2 comments
Open

Sphinx 2.1.2 breaks our github plugin #60

tkell opened this issue Jul 28, 2019 · 2 comments

Comments

@tkell
Copy link
Collaborator

tkell commented Jul 28, 2019

Hello @bmcfee!

Via Katie Kinnaird, we now get this:

$ make html
sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v2.1.2

Exception occurred:
  File "/Users/denise.nava/ismir2018-oss-tutorial/doc/sphinxext/github.py", line 149, in setup

    app.info('Initializing GitHub plugin')

AttributeError: 'Sphinx' object has no attribute 'info'

I fixed this by installing Sphinx 1.8.5. We can spec that version in our requirements, or update the github.py in our doc/ directory. What do you think?

@bmcfee
Copy link
Owner

bmcfee commented Jul 29, 2019

Huh, I didn't realize that this was in there. Do we need this github extension, or can we get rid of it?

@tkell
Copy link
Collaborator Author

tkell commented Jul 29, 2019

I can't find it being used in our codebase - I vote for removal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants