Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double sign may happen after restart #2598

Closed
buddh0 opened this issue Jul 19, 2024 · 2 comments
Closed

double sign may happen after restart #2598

buddh0 opened this issue Jul 19, 2024 · 2 comments
Assignees

Comments

@buddh0
Copy link
Collaborator

buddh0 commented Jul 19, 2024

System information

worker.recentMinedBlocks is empty when node start, and not jounalized
so may miss some double sign checking

Geth version: geth version
OS & Version: Windows/Linux/OSX
Commit hash : (if develop)

Expected behaviour

Actual behaviour

Steps to reproduce the behaviour

Backtrace

[backtrace]

When submitting logs: please submit them as text and not screenshots.

@buddh0 buddh0 self-assigned this Jul 25, 2024
@buddh0
Copy link
Collaborator Author

buddh0 commented Jul 25, 2024

low prority

@buddh0
Copy link
Collaborator Author

buddh0 commented Aug 20, 2024

only happens in the following scene:

  1. validator mined a block and write the block into db
  2. before writing the block as the head block, validator is force killed
  3. immediately, restart the validator, it will try to mine another block at the same height.

for validators, force kill should be avoid.
so ,the probability of this scenario happening is extremely low

@buddh0 buddh0 closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant