Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay in data Json Generate, causes errors when saving. #18

Open
libastian opened this issue Mar 7, 2016 · 2 comments
Open

Delay in data Json Generate, causes errors when saving. #18

libastian opened this issue Mar 7, 2016 · 2 comments

Comments

@libastian
Copy link

I have observed a fairly long delay (3 sec), to generate the Json with seo information in the hidden field:

https://github.com/bobdenotter/seo/blob/master/twig/_seo_extension_field.twig#L213

If you perform any changes in the fields located at the bottom of page (e.g .: Meta robots tag - Shortlink alias) and quickly you click on the save button, this change is not saved.

I checked that everything works properly changing to 0 the delay value.

Why do you set that delay?

@melcarthus
Copy link

Second this. I'm not able to save the setting for meta-robots-tags. Did not know it was because of this delay.

@xiaohutai
Copy link
Contributor

I've noticed too when working on this extension. It's this part now:
https://github.com/bobdenotter/seo/blob/master/templates/_seo_extension_field.twig#L224

I do feel 3000ms is a bit too much. I wonder if throttling / debouncing the update function would be a better idea. Or ideally, just before the save button is clicked (if that's even possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants