Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support uniform subdivision in addition to adaptive #36

Open
boberfly opened this issue Jan 9, 2020 · 0 comments
Open

Support uniform subdivision in addition to adaptive #36

boberfly opened this issue Jan 9, 2020 · 0 comments
Assignees
@boberfly
Labels
enhancement New feature or request
Milestone
1.0

Comments

@boberfly
Copy link
Owner

boberfly commented Jan 9, 2020 •
edited
Loading

More of a Cycles-specific patch. Currently Cycles relies on Blender to do uniform subdivision so this makes it currently impossible to just tag a mesh as uniform subdivision over adaptive. This will allow the mesh to be instanced.

The code here looks like we could use ->UniformRefine() by what we see from SubdivisionType
https://github.com/boberfly/cycles/blob/77086fc932a05d52a86781f3d081698b3c9ad2a9/src/render/mesh_subdivision.cpp#L182

Looks very easy to implement, famous last words.
@boberfly boberfly added the enhancement New feature or request label Jan 9, 2020
@boberfly boberfly added this to the 1.0 milestone Jan 9, 2020
@boberfly boberfly self-assigned this Jan 9, 2020
@boberfly boberfly mentioned this issue Jan 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boberfly boberfly

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@boberfly