Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user verification #16

Open
Samjna-nh opened this issue Nov 11, 2024 · 3 comments
Open

Support user verification #16

Samjna-nh opened this issue Nov 11, 2024 · 3 comments

Comments

@Samjna-nh
Copy link

If the relying party set the user verification requirement option to required, the authenticator should return data with the UV flag on, or fail if it cannot do the user verification (spec).
What other virtual authenticators usually do is to add an argument in the constructor to indicate whether the authenticator can do the user verification. And when create / get you compare the setting with the options from RP to update flags / throw errors.
At least, a simple implementation that allow you customize the flags when doing create / get satisfies most cases, otherwise there's no way to do some tests with an RP requiring user verification.

@bodik
Copy link
Owner

bodik commented Nov 11, 2024

would this be resolved by #15 ?

@Samjna-nh
Copy link
Author

Yes, exactly what I want.
Still it would be an option to have a user verification option in the constructor or (create & get) though, but that PR solves most problems.

@bodik
Copy link
Owner

bodik commented Nov 11, 2024

thank's for review. i'll try to get the PR merged but no guarantees on timeframe thou ;/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants