Bug in vulnerable biomass equation

[ChrisFishCahill]

There is a bug in the vulnerable biomass as currently calculated, for example see here:

https://github.com/boettiger-lab/rl4fisheries/blob/rppo-n-viz/src/rl4fisheries/envs/asm_2o.py#L223

This p["mwt"] is for prediction of the spawning stock biomass (SSB) used in recruitment predictions, and should actually be p["wt"], as the latter is for prediction of the biomass vulnerable to harvesters.

So to get the time values for vulnerable biomass (visible to harvesters and/or surveys), we need to replace p["mwt"] with p["wt"] in the following files:

asm.py

asm_2o.py

asm_esc.py

Sorry, this bug must have been lost in translation when I converted this from earlier languages to Python.

[felimomo]

Thanks so much, it's great to have caught that! And no worries about it!

To be clear (sometimes 'replace with' can be ambivalent in direction):

we need to change p["mwt"] -> p["wt"], right? Do we also need to replace p["wt"] -> p["mwt"]?

[ChrisFishCahill]

Sorry for the ambiguity. I meant that the following line:

self.vulb = sum(p["vul"] * n * p["mwt"])

should instead be the following:

self.vulb = sum(p["vul"] * n * p["wt"])

I checked the rest of the script--I don't think any further corrections are needed right now--the other locations that p["wt"] or p["mwt"] are called look OK.

[felimomo]

Cool! It's now fixed on pull request #9. (Should be merged into the main branch soon!)