From 6ce9d3f3bb285caef07b03af32d7b552a0882220 Mon Sep 17 00:00:00 2001 From: Hannes Winkler Date: Fri, 13 Oct 2023 16:21:23 +0200 Subject: [PATCH] add todo for upload using gst_gl_upload --- src/plugins/gstreamer_video_player/frame.c | 2 +- src/plugins/gstreamer_video_player/player.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/gstreamer_video_player/frame.c b/src/plugins/gstreamer_video_player/frame.c index 9d9291a0..66498ce6 100644 --- a/src/plugins/gstreamer_video_player/frame.c +++ b/src/plugins/gstreamer_video_player/frame.c @@ -622,7 +622,7 @@ get_plane_infos(GstBuffer *buffer, const GstVideoInfo *info, struct gbm_device * if (n_memories != 1) { ok = dup_gst_buffer_range_as_dmabuf(gbm_device, buffer, memory_index, n_memories); if (ok < 0) { - LOG_ERROR("Could not duplicate gstreamer memory as dmabuf.\n"); + LOG_ERROR("Could not duplicate gstreamer buffer range as dmabuf.\n"); ok = EIO; goto fail_close_fds; } diff --git a/src/plugins/gstreamer_video_player/player.c b/src/plugins/gstreamer_video_player/player.c index 8c948cda..6dedd04f 100644 --- a/src/plugins/gstreamer_video_player/player.c +++ b/src/plugins/gstreamer_video_player/player.c @@ -767,6 +767,7 @@ static GstFlowReturn on_appsink_new_preroll(GstAppSink *appsink, void *userdata) return GST_FLOW_ERROR; } + /// TODO: Attempt to upload using gst_gl_upload here frame = frame_new(player->frame_interface, sample, player->has_gst_info ? &player->gst_info : NULL); gst_sample_unref(sample); @@ -795,6 +796,7 @@ static GstFlowReturn on_appsink_new_sample(GstAppSink *appsink, void *userdata) player = userdata; + /// TODO: Attempt to upload using gst_gl_upload here sample = gst_app_sink_try_pull_sample(appsink, 0); if (sample == NULL) { LOG_ERROR("gstreamer returned a NULL sample.\n");