Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPython 2 #12

Closed
4 tasks
bollwyvl opened this issue Apr 11, 2015 · 4 comments
Closed
4 tasks

Support IPython 2 #12

bollwyvl opened this issue Apr 11, 2015 · 4 comments

Comments

@bollwyvl
Copy link
Owner

IPython 2.0 will be around for a while (RHEL, etc), and there are lots of v3 notebooks out there, just waiting to become tests. Supporting these looks not crazy.

@gramster how would you feel about either me stealing your changes related to this, or you working up a PR? Regarding that change: the startup script stuff seems a bit odd: how do you generate a known good notebook if something else has to happen to get the right output?

@gramster
Copy link

I'm quite happy with you stealing my changes.

The startup script is because we have a config.py that gets loaded in our environment and I need to load that in the test environment too (it contains just a single import in our case).

@bollwyvl
Copy link
Owner Author

Lovely. I'm working on setting up tox for py2/3 and ipy2/3/4, so this is
very timely. will end up being lots of very, very similar notebooks :P

As to the config, i'm happy to bring in something like that (on another
PR), but maybe under another, more nose-like name... perhaps it's more like
a "setup". Feel free to raise an issue for discussion!

On Mon, Apr 13, 2015 at 1:16 PM, Graham Wheeler [email protected]
wrote:

I'm quite happy with you stealing my changes.

The startup script is because we have a config.py that gets loaded in our
environment and I need to load that in the test environment too (it
contains just a single import in our case).


Reply to this email directly or view it on GitHub
#12 (comment).

@bollwyvl
Copy link
Owner Author

@gramster 0.4.0, also up on pip, adds IPython 2 support! I've also opened an issue #14 for the config ne setup feature.

@gramster
Copy link

Thanks muchly. We're in a bit of a crunch right now so I haven't had a chance to test but should get to it by next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants