Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tensorflow to 2.2.3? #30

Open
r-wheeler opened this issue May 27, 2020 · 8 comments
Open

Bump tensorflow to 2.2.3? #30

r-wheeler opened this issue May 27, 2020 · 8 comments

Comments

@r-wheeler
Copy link

r-wheeler commented May 27, 2020

I found a few tflite ops (mostly rnn related) that were supported in the master of tensorflow but not in the specific commit these bindings were built against. I was able to compile updated bindings by

  • updating the tensorflow submodule to point to master
  • updating the downloads (the tflite delegates now need absl)
  • and updating the build.rs by adding:

.clang_arg(format!("-I{}/downloads/absl/", submodules_str) to Builder
.include(submodules.join("downloads/absl/")) to cpp_build::Config

Would you be open to a PR bumping the tensorflow version to incorporate some of the new ops / changes to tflite?

@boncheolgu
Copy link
Owner

Hi, thanks for the interest.
You are welcome to open a PR. I'll check it.

@r-wheeler
Copy link
Author

Thanks, will look at getting a PR in the works. Currently debugging why the crate works correctly if I set cargo to install from a local directory (after running update-downloads) but not when pointing to my fork on github.

./third_party/eigen3/Eigen/Core:1:10: fatal error: 'Eigen/Core' file not found
#include "Eigen/Core"
         ^~~~~~~~~~~~

@nemosupremo
Copy link

nemosupremo commented Jun 9, 2020

@r-wheeler

I've been evaluating the library and I had to update tensorflow to a different commit for a different use case. I was able to get it to build in my forks. The steps were as follows

  1. Update the submodules for tensorflow (in my case I needed commit tensorflow/tensorflow@d855adf ~2.2.0).
  2. Run update_downloads.sh to update the downloads submodule (this will download the new deps for the new tensorflow version).
  3. Patch the Makefile so that the project builds. I came across two issues (TensorFlow Lite: Makefile fix tensorflow/tensorflow#35869, libtensorfow-lite.a linking issue tensorflow/tensorflow#36689) that solved the linking issue. In my case, since I didn't want to fork tensorflow, I just included the patched Makefile in my tflite-rs fork and then I copy it over to the tflite build process in build.rs.

@r-wheeler
Copy link
Author

@nemosupremo How did this library work out for you? Going to try to work up opening a PR in here to bump to latest stable tensorflow

@nemosupremo
Copy link

nemosupremo commented Oct 24, 2020

@r-wheeler I needed to use a seperate commit for compatibility with Google's Edge TPU library. I've been using my fork for months without issue.

@wisonye
Copy link

wisonye commented Nov 30, 2020

@r-wheeler I needed to use a seperate commit for compatibility with Google's Edge TPU library. I've been using my fork for months without issue.

@r-wheeler Hi there, I do need the Google's Edge TPU support for my current project, any update? 👍

@ericmcbride
Copy link

@r-wheeler I currently have it compiling to 2.4, just extended off of nemosupremo's solution and had to install googlemock to my usr/includes, and it worked fine.

@bkirwi
Copy link
Contributor

bkirwi commented Mar 10, 2021

Opened a PR for a bump to 2.4.1: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants