From 6b26f187e7ca9ab2ca63f961267458db94424091 Mon Sep 17 00:00:00 2001 From: AndriyShykin <128408172+AndriyShykin@users.noreply.github.com> Date: Thu, 12 Dec 2024 14:43:39 +0200 Subject: [PATCH] Update setTimeoutSec page object method (#1072) Added wait object update when timeoutSec value changes. --- .../bonigarcia/webdriver/junit4/ch07/page_objects/BasePage.java | 1 + .../webdriver/junit4/ch07/page_objects/ExtendedBasePage.java | 1 + .../bonigarcia/webdriver/seljup/ch07/page_objects/BasePage.java | 1 + .../webdriver/seljup/ch07/page_objects/ExtendedBasePage.java | 1 + .../bonigarcia/webdriver/jupiter/ch07/page_objects/BasePage.java | 1 + .../webdriver/jupiter/ch07/page_objects/ExtendedBasePage.java | 1 + .../bonigarcia/webdriver/testng/ch07/page_objects/BasePage.java | 1 + .../webdriver/testng/ch07/page_objects/ExtendedBasePage.java | 1 + 8 files changed, 8 insertions(+) diff --git a/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/BasePage.java b/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/BasePage.java index 5ae1b2f36..277642b3b 100644 --- a/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/BasePage.java +++ b/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/BasePage.java @@ -44,6 +44,7 @@ public BasePage(WebDriver driver) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void visit(String url) { diff --git a/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/ExtendedBasePage.java b/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/ExtendedBasePage.java index 7c982f44f..5a0d09c74 100644 --- a/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/ExtendedBasePage.java +++ b/selenium-webdriver-junit4/src/test/java/io/github/bonigarcia/webdriver/junit4/ch07/page_objects/ExtendedBasePage.java @@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void quit() { diff --git a/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/BasePage.java b/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/BasePage.java index c85bd44c6..53684524e 100644 --- a/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/BasePage.java +++ b/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/BasePage.java @@ -44,6 +44,7 @@ public BasePage(WebDriver driver) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void visit(String url) { diff --git a/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/ExtendedBasePage.java b/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/ExtendedBasePage.java index c1baca3a0..f0388785f 100644 --- a/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/ExtendedBasePage.java +++ b/selenium-webdriver-junit5-seljup/src/test/java/io/github/bonigarcia/webdriver/seljup/ch07/page_objects/ExtendedBasePage.java @@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void quit() { diff --git a/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/BasePage.java b/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/BasePage.java index 4c8c2c8c3..9f7b2dfb8 100644 --- a/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/BasePage.java +++ b/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/BasePage.java @@ -44,6 +44,7 @@ public BasePage(WebDriver driver) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void visit(String url) { diff --git a/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/ExtendedBasePage.java b/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/ExtendedBasePage.java index 48f378472..ef4052b0f 100644 --- a/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/ExtendedBasePage.java +++ b/selenium-webdriver-junit5/src/test/java/io/github/bonigarcia/webdriver/jupiter/ch07/page_objects/ExtendedBasePage.java @@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void quit() { diff --git a/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/BasePage.java b/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/BasePage.java index 10ce86624..67c32c7bb 100644 --- a/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/BasePage.java +++ b/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/BasePage.java @@ -44,6 +44,7 @@ public BasePage(WebDriver driver) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void visit(String url) { diff --git a/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/ExtendedBasePage.java b/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/ExtendedBasePage.java index a9fcf222e..462a88cd9 100644 --- a/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/ExtendedBasePage.java +++ b/selenium-webdriver-testng/src/test/java/io/github/bonigarcia/webdriver/testng/ch07/page_objects/ExtendedBasePage.java @@ -47,6 +47,7 @@ public ExtendedBasePage(String browser) { public void setTimeoutSec(int timeoutSec) { this.timeoutSec = timeoutSec; + this.wait = new WebDriverWait(driver, Duration.ofSeconds(timeoutSec)); } public void quit() {