Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resultsOpen.php to not duplicate code from results.php #4

Open
timjackson opened this issue May 11, 2017 · 0 comments
Open

Comments

@timjackson
Copy link
Collaborator

Currently there is a high level of duplication of code from results.php to resultsOpen.php. i.e. take the assessment logic out and call it from both pages. Which needs to be done anyway, to make it easier to work on the assessment logic separate from the presentation.

It could also be considered to merge resultsOpen.php with results.php, and use a stylesheet to make a "printable" version. However, in practice, the "printable" version is not really a printable version, but primarily a template to be exported out to a wordprocessor for further processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant