Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wire delimiting #10

Open
bookmoons opened this issue Aug 12, 2018 · 1 comment
Open

Improve wire delimiting #10

bookmoons opened this issue Aug 12, 2018 · 1 comment
Labels

Comments

@bookmoons
Copy link
Owner

The current protocol uses the Unicode character U+23CE Return Symbol in UTF-8 to terminate messages on the wire. In binary this is the 3 byte sequence e2 8f 8e.

I'm not completely comfortable with this. I don't think there's any guarantee that this byte sequence won't end up in a message.

Update the protocol to use some safe mechanism of message delimiting.

@bookmoons
Copy link
Owner Author

The CashShuffle team have agreed on using a length prefix scheme. Specifics to be determined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant