Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize conversion logic #17

Open
bookmoons opened this issue Sep 10, 2018 · 9 comments
Open

Centralize conversion logic #17

bookmoons opened this issue Sep 10, 2018 · 9 comments
Labels
refactor

Comments

@bookmoons
Copy link
Owner

Strings are converted to ArrayBuffer instances in several places. This should be centralized in the util module.
@bookmoons
Copy link
Owner Author

Hex string ArrayBuffer conversions implemented in hexToBytes bytesToHex.

Base64 conversions pending.

@bookmoons
Copy link
Owner Author

Usage of the module array-buffer-to-hex can also be replaced.

@bookmoons
Copy link
Owner Author

Base64 TypedArray conversions implemented in base64ToBytes bytesToBase64.

@bookmoons
Copy link
Owner Author

Replaced and removed array-buffer-to-hex.

@bookmoons
Copy link
Owner Author

UTF-8 TypedArray conversions implemented in stringToUtf8 utf8ToString.

@bookmoons
Copy link
Owner Author

All Base64 conversions replaced.

@bookmoons
Copy link
Owner Author

All UTF-8 conversions replaced.

@bookmoons bookmoons changed the title Centralize string to ArrayBuffer logic Centralize conversion logic Sep 18, 2018
@bookmoons
Copy link
Owner Author

All internal Buffer.from usage replaced.

@bookmoons
Copy link
Owner Author

All internal Buffer.toString usage replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bookmoons