You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The event rework is nice, but as an example: PlayerLeaveTeamEvent: it triggers BEFORE the actual thing happened. Now, if this gets cancelled by 1 plugin, but intercepted by a 2nd one. Plugin1 will know it's cancelled, but Plugin2 will not if it came before. Or for example with donations, there are so many ways it still can fail, so you don't know for sure if the event took place.
Thus my proposal: split all these into Pre & Post events so if you want to know something happened (and it is finalized): listen to the post-event. If you want to interact with the event: listen to the pre-event.
I already did this in my own codebase and could integrate it into BetterTeams, but if it's not needed, I'm not going to do the efforts obviously.
attention: this will likely break a lot of plugins, because the event names nearly all changed from <name> to <Pre>name because most of them were cancellable, and not the final state. If you have any suggestion for this to break less, I'm happy to hear it.
Relevant links
No response
Additional Information
No response
Feature requests are not going to be implemented by booksaw, instead you will have to find another developer to make a pull request to implement the feature.
I understand
The text was updated successfully, but these errors were encountered:
What is the feature request for?
Hello,
The event rework is nice, but as an example:
PlayerLeaveTeamEvent
: it triggers BEFORE the actual thing happened. Now, if this gets cancelled by 1 plugin, but intercepted by a 2nd one. Plugin1 will know it's cancelled, but Plugin2 will not if it came before. Or for example with donations, there are so many ways it still can fail, so you don't know for sure if the event took place.Thus my proposal: split all these into Pre & Post events so if you want to know something happened (and it is finalized): listen to the post-event. If you want to interact with the event: listen to the pre-event.
I already did this in my own codebase and could integrate it into BetterTeams, but if it's not needed, I'm not going to do the efforts obviously.
attention: this will likely break a lot of plugins, because the event names nearly all changed from
<name>
to<Pre>name
because most of them were cancellable, and not the final state. If you have any suggestion for this to break less, I'm happy to hear it.Relevant links
No response
Additional Information
No response
Feature requests are not going to be implemented by booksaw, instead you will have to find another developer to make a pull request to implement the feature.
The text was updated successfully, but these errors were encountered: