Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC suggest-override warnings #27

Open
EugeneZelenko opened this issue Apr 12, 2020 · 2 comments
Open

GCC suggest-override warnings #27

EugeneZelenko opened this issue Apr 12, 2020 · 2 comments

Comments

@EugeneZelenko
Copy link

EugeneZelenko commented Apr 12, 2020

Complete list of warnings when Boost 1.72 is built with GCC 7.5 with -Wsuggest-override added to cxxflags:

./boost/contract/core/exception.hpp:107:25: warning: ‘virtual const char* boost::contract::bad_virtual_result_cast::what() const’ can be marked override [-Wsuggest-override]
./boost/contract/core/exception.hpp:183:25: warning: ‘virtual const char* boost::contract::assertion_failure::what() const’ can be marked override [-Wsuggest-override]

BOOST_OVERRIDE was introduced in boostorg/config@ffe4e0f.

@lcaminiti
Copy link
Member

This can be fixed using BOOST_OVERRIDE that should become part of Boost.Config from the next release: boostorg/config#329.
However, I will not generate a new release or Boost.Contract only to fix warnings. I will leave this issue open. If I have to generate a new Boost.Contract release in the future, I will then fix this warning as well.

@EugeneZelenko
Copy link
Author

See fixes in #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants