Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative integration with other tasks, without .cljs.edn #169

Open
Deraen opened this issue Aug 4, 2017 · 1 comment
Open

Alternative integration with other tasks, without .cljs.edn #169

Deraen opened this issue Aug 4, 2017 · 1 comment
Milestone

Comments

@Deraen
Copy link
Contributor

Deraen commented Aug 4, 2017

Currently boot-reload and boot-cljs-repl use .cljs.edn files to tell boot-cljs about namespaces that have to be included in the build. Without .cljs.edn file Boot-cljs falls back to compiling EVERY .cljs file in the fileset. This is usually bad choice.

I think this could be solved by adding another way for other tasks to contribute to Boot-cljs, in addition to the file. Fileset metadata (meta) should be easy way to solve this (Clojure metadata on the fileset object, not Boot Fileset metadata, which is tied to files). This will need some testing...

Things to consider:

  • How will this work with several cljs builds in the pipeline?
  • What if reload is only enabled for some of the builds?

Also, can :ids be replaced with something else? Maybe the ID could be set manually instead of using the path of the file. That would allow tasks to communicate without .cljs.edn files, and would be even simpler than using the paths.

@arichiardi
Copy link
Contributor

Agree that adding meta with clear semantic on what is merged into what, can be a good option (actually the only one left 😄). About build ids, probably some sort of sanity check should make sure we build and reload the same things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants