Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser tests #45

Open
10xjs opened this issue Mar 14, 2018 · 0 comments
Open

Add browser tests #45

10xjs opened this issue Mar 14, 2018 · 0 comments
Labels
enhancement flowtip-react-dom

Comments

@10xjs
Copy link
Contributor

10xjs commented Mar 14, 2018

The simulated DOM used in jest tests isn't capable of providing the required layout information for flowtip to operate properly. (getBoundingClientRect and getComputedStyle are both stubbed to return constant mock results)

We need to set up in-browser tests (potentially using https://saucelabs.com/open-source) to create proper test coverage for flowtip-react-dom.
@10xjs 10xjs changed the title [flowtip-react-dom] Add browser tests Add browser tests Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement flowtip-react-dom
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@10xjs