Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Screen Readers #31

Open
Ariel-Thomas opened this issue Apr 17, 2014 · 1 comment
Open

Supporting Screen Readers #31

Ariel-Thomas opened this issue Apr 17, 2014 · 1 comment

Comments

@Ariel-Thomas
Copy link

Currently, from a screen reader perspective, the pages are not obviously labeled as such. Bootstrap 3.0 provides the 'sr-only' class to allow bits of html to only be shown to screen readers. The pages should really have a span which includes "Page " in front of them to make things easier on screen readers. The result for a screen reader list of links goes from "1", "2", "3 to "Page 1" "Page 2", "Page 3".

I used your existing renderer code for rails and made this addition and it seems to work fine. Perhaps in the gem this should be the default behavior with a will_paginate option to disable it?

I can do a pull request with the changes, if needed.

@acrogenesis
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants