Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Undo is less reliable #446

Open
schanzer opened this issue Oct 9, 2021 · 1 comment
Open

Regression: Undo is less reliable #446

schanzer opened this issue Oct 9, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@schanzer
Copy link
Member

schanzer commented Oct 9, 2021

  1. Start the editor with the standard sample file.
  2. Switch to blocks mode.
  3. Drag the multiply expression (line 13), and drop it on the -5 inside the if-expression (line 15).
  4. Hit Ctrl-Z

EXPECTED: the drag operation is undone
ACTUAL: nothing

There are other examples where this fails (deleting an expression and then hitting undo(), for example), but I suspect that they are all symptoms of the same problem.

@pcardune pcardune added the bug label Oct 14, 2021
@schanzer schanzer modified the milestones: pre-alpha, alpha Oct 20, 2021
@schanzer
Copy link
Member Author

schanzer commented Nov 3, 2021

Poked at this today - it looks like undo actually does the right thing, but the BlockEditor fails to re-render to show the transformed blocks. In BlockEditor::handleChange(), actionFocus is being retrieved as undefined. As a result, no action is fired and there is no call to commitChanges()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants