-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data resolution and completeness Check #5
Comments
Hi @Yassminaa:
This looks correct to me. If one time step is missing the temporal check fails. Completeness only checks for NaNs (i.e., if there are NaNs anywhere or in unmasked regions when a mask is provided).
Good catch, thanks! The checker currently only works with regular time deltas (e.g., 30 days). I'll make a couple of changes to allow you to specify monthly, yearly, ...
The vertical check is done through
The test passes if I set in the configfile any subset of the following:
From terminal, run |
@Yassminaa the issue with monthly data should be fixed now. Could you please test the latest version and let me know?
|
I have tested the updated code,
|
Good news! |
Yes. Now passed. Thanks @malmans2 Would also be great if you put an example in the configuration file for the alias of time-frequency |
The link to pandas aliases was already there, but I also added an example for monthly data as they are quite common and the alias is somewhat tricky:
|
Hi @malmans2
I have used the tool on ERA5 (single levels and vertical levels). It probably worked on the complete file of hourly file, but when one timestep in between is missing,
The check failed in the temporal resolution, not the completeness check (see the attached log file log.test-completeness.txt )
For monthly data. I got the following error regarding the temporal resolution: ("ValueError: invalid unit abbreviation: month")
where I set the temporal resolution as 1 month in the configuration file.
** For Vertical coverage: In the generated template, I couldn't see any check for the completeness of the vertical coverage.
when some levels are missed from the file, the test passes.
I assume I should define somewhere the min/max level for the coverage check, or levels values, but I couldn't find this in the template. May you please guide me on how I can do this, if the check is included in the tool?
Thank you,
The text was updated successfully, but these errors were encountered: