Skip to content
This repository has been archived by the owner on Sep 19, 2019. It is now read-only.

Clean up use of _connections in ConnectionManager #12

Open
makkes opened this issue Nov 15, 2013 · 1 comment
Open

Clean up use of _connections in ConnectionManager #12

makkes opened this issue Nov 15, 2013 · 1 comment
Assignees

Comments

@makkes
Copy link

makkes commented Nov 15, 2013

Currently the CM holds all open connections in the _connections object. There are several issues with this:

  1. _connections is never cleaned up (e.g. when a connection is lost or closed)
  2. The router also holds refs to all open DCs. This seems redundant.

We have to figure out where to store the list of open connections and which component is responsible for acting upon events (like 'close') on them. Possibilities:

  • Let the CM hold refs to all open connections. If e.g. the Router needs to send data on a connection it requests this connection from the CM.
  • Let the Router hold refs to all open connections. The CM then asks the Router if a connection is already open for doing maintenance (like denying subsequent offers)
  • Put this logic into Peer objects.
@ghost ghost assigned makkes Nov 15, 2013
@chris--
Copy link
Member

chris-- commented Nov 19, 2014

Closed in develop as we don't use _connections anymore since 591b963

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants