Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: Include changes to outputs in pull request comments #24

Open
ricardofalc opened this issue Oct 9, 2024 · 2 comments
Open

idea: Include changes to outputs in pull request comments #24

ricardofalc opened this issue Oct 9, 2024 · 2 comments

Comments

@ricardofalc
Copy link

Hi,

I've noticed that changes to outputs from the terraform plan are not being reflected in the pull request comments generated by this action.

Could you clarify if this is a design choice or a potential enhancement? It would be really helpful to have these output changes listed along with other modifications in the plan for better visibility during code reviews.

Thanks for the great work on this action! I’m looking forward to your feedback.

Comment in PR indicates there are no changes:
image

Terraform plan in workflow indicates the following:
image

@borchero
Copy link
Owner

Good catch, I think that would be a great addition to this action! Unfortunately, it is currently unsupported.

I'd be happy to review a PR for this, it would take me a some time until I'd find the time to see through the implementation myself 👀

@ricardofalc ricardofalc changed the title idea: Include Changes to Outputs in Pull Request Comments idea: Include changes to outputs in pull request comments Oct 25, 2024
Copy link

🤖 Stalebot

This issue hasn't seen updates in the last 60 days.

If it has been resolved or won't be worked on, please consider closing the issue. Otherwise, it will be closed automatically in 30 days.

@github-actions github-actions bot added the stale label Feb 15, 2025
@borchero borchero removed the stale label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants