build: migrate from setuptools to poetry (use pyproject.toml for build) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2024 12:43
|
This is an alternative to PR #150, using the more-well-known poetry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the build system to poetry, greatly simplifying the build, and updates the documentation to reflect the change.
Installs now require a no-hastle 'pip install .'. Ensures proper version pinning on development, as well.
closes #154 #141 #47 and also, since PyQT5 apparently now has arm builds and versions are now pinned and on their own venv, #119 #47
Also is a step forward towards closing #15. To close it, only
poetry publishis needed, although publishing it with a Github Action will probably be wiser to ensure no more work is required.Implements part of #149, and is a step towards easily building distributable binaries on GHA in the future.
@bordaigorl LMK if you have any issues running it following the new README (if it's clear enough).