Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtsam can't customize factors, can't override the evaluateError() function, and gtsam version is 4.2.0. #1907

Closed
WangWenda98 opened this issue Nov 28, 2024 · 1 comment

Comments

@WangWenda98
Copy link

Description

gtsam can't customize factors, can't override the evaluateError() function, and gtsam version is 4.2.0.
2024-11-28 11-27-40 的屏幕截图

source code:
`#include <gtsam/base/Vector.h>
#include <gtsam/linear/NoiseModel.h>
#include <gtsam/nonlinear/NonlinearFactor.h>
#include <gtsam/nonlinear/DoglegOptimizer.h>
#include <gtsam/nonlinear/GaussNewtonOptimizer.h>
#include <gtsam/nonlinear/LevenbergMarquardtOptimizer.h>
#include <gtsam/inference/Key.h>
#include <gtsam/inference/Symbol.h>
#include <gtsam/nonlinear/Values.h>
#include <opencv2/core/core.hpp>
#include
#include <boost/optional.hpp>
#include "matplotlibcpp.h"
#include

using namespace std;
using namespace gtsam;

namespace plt = matplotlibcpp;

// y = exp(a x^2 + b x + c)
// 利用x和参数a,b,c计算y
double funct(const gtsam::Vector3 &p, const double x)
{
return exp(p(0) * x * x + p(1) * x + p(2));
}

// 自定义类名 : 继承于一元因子类<优化变量的数据类型>
class curvfitFactor : public gtsam::NoiseModelFactor1gtsam::Vector3
{
double mx, my; // 观测值

public:
curvfitFactor(gtsam::Key key, const gtsam::SharedNoiseModel &noise, double x, double y)
: gtsam::NoiseModelFactor1gtsam::Vector3(noise, key), mx(x), my(y)
{
}
virtual ~curvfitFactor()
{
}

// 自定义因子一定要重写evaluateError函数(优化变量, 雅可比矩阵)
gtsam::Vector evaluateError(const gtsam::Vector3 &p, boost::optional<gtsam::Matrix &> H = boost::none) const override
{
    auto val = funct(p, mx);
    if (H) // 残差为1维,优化变量为3维,雅可比矩阵为1*3
    {
        gtsam::Matrix Jac = gtsam::Matrix::Zero(1, 3);
        Jac << mx * mx * val, mx * val, val;
        (*H) = Jac;
    }
    return gtsam::Vector1(val - my); // 返回值为残差
}

};

int main()
{
using gtsam::symbol_shorthand::X;
// const double sig = 1;
// std::random_device rd;
// std::default_random_engine generator_(rd());
// std::normal_distribution noise(0, sig);
gtsam::NonlinearFactorGraph graph;
const gtsam::Vector3 para(1.0, 2.0, 1.0); // a,b,c的真实值
double w_sigma = 1.0; // 噪声Sigma值
double inv_sigma = 1.0 / w_sigma;
cv::RNG rng; // OpenCV随机数产生器

vector<double> x_data, y_data;

for (int i = 0; i < 100; ++i)
{
    double mx = i / 100.0;
    auto my = funct(para, mx) + rng.gaussian(w_sigma * w_sigma); // 加入了噪声数据
    auto noiseM = gtsam::noiseModel::Isotropic::Sigma(1, w_sigma); // 噪声的维度需要与观测值维度保持一致
    graph.emplace_shared<curvfitFactor>(X(0), noiseM, mx, my);     // 加入一元因子

    x_data.push_back(mx);
    y_data.push_back(my);
}

gtsam::Values intial;
intial.insert<gtsam::Vector3>(X(0), gtsam::Vector3(2.0, -1.0, 5.0));

// DoglegOptimizer opt(graph, intial); // 使用Dogleg优化
// GaussNewtonOptimizer opt(graph, intial); // 使用高斯牛顿优化
LevenbergMarquardtOptimizer opt(graph, intial); // 使用LM优化
std::cout << "initial error=" << graph.error(intial) << std::endl;
auto res = opt.optimize();
res.print("final res:");

std::cout << "final error=" << graph.error(res) << std::endl;

gtsam::Vector3 matX0 = res.at<gtsam::Vector3>(X(0));
std::cout << "a b c: " << matX0 << "\n";

/************* 绘制曲线************************/
int n = 5000;
std::vector<double> x(n), y(n), w(n, 2);
for (int i = 0; i < n; ++i)
{
    x.at(i) = i * 1.0 / n;
    y.at(i) = exp(matX0(0) * x[i] * x[i] + matX0(1) * x[i] + matX0(2));
}

plt::figure_size(640, 480);

plt::plot(x_data, y_data, "ro");
plt::plot(x, y, {{"color", "blue"}, {"label", "$y = e^{ax^2+bx+c}$"}});

plt::show();

return 0;

}

@ProfFan
Copy link
Collaborator

ProfFan commented Dec 1, 2024

Hi, since this is most likely user error please either use the mailing list or the forums, thanks!

@ProfFan ProfFan closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants