Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if offer is token-gated with a range on voucher preMint #713

Open
anajuliabit opened this issue Jul 17, 2023 · 1 comment
Open

Verify if offer is token-gated with a range on voucher preMint #713

anajuliabit opened this issue Jul 17, 2023 · 1 comment

Comments

@anajuliabit
Copy link
Contributor

We need to verify if a range condition is set for the offer when the seller pre-mints the rNFTs. If a pre-minted token is created for a token-gated offer with a range, the transaction that transfers the rNFT to the buyer immediately fails. Currently, there is no risk of losing funds since the buyer will never commit to the offer, and the only possible action for the seller is to burn the preminted vouchers.

we should also consider addressing this on the reserveRange.

@anajuliabit anajuliabit changed the title Verify if offer is token-gated with a range when preMinting vouchers Verify if offer is token-gated with a range on voucher preMint Jul 17, 2023
@zajck
Copy link
Member

zajck commented Nov 20, 2023

Need to verify that this is still an issue after all the changes done during the price discovery implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants