Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BES-01C] Lingering TODO Comments #866

Open
zajck opened this issue Jan 8, 2024 · 0 comments
Open

[BES-01C] Lingering TODO Comments #866

zajck opened this issue Jan 8, 2024 · 0 comments

Comments

@zajck
Copy link
Member

zajck commented Jan 8, 2024

BES-01C: Lingering TODO Comments

Type Severity Location
Code Style BosonErrors.sol:L9, L25, L27, L31, L40, L234, L262

Description:

The referenced comments represent TODO statements that have yet to be resolved in the codebase.

Example:

// Whenever a region is paused, and a method from that region is called
error RegionPaused(); //ToDo consider adding the region to the error message

Recommendation:

We advise them to be resolved, especially the ones referencing input arguments to error declarations as they would be inconsequential gas-wise and would greatly enhance off-chain debugging capabilities.

@zajck zajck self-assigned this Jan 8, 2024
@zajck zajck removed their assignment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant