Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accuracy of Helper.cubicRoots() #23

Open
bourgesl opened this issue Feb 1, 2018 · 2 comments
Open

Improve accuracy of Helper.cubicRoots() #23

bourgesl opened this issue Feb 1, 2018 · 2 comments

Comments

@bourgesl
Copy link
Owner

bourgesl commented Feb 1, 2018

  1. Use final newton root refinement in cubic roots solve to refine accuracy
  2. For clip intersections (xPoints, yPoints), ensure x(t) or y(t) are outside of the clip (side issue) => extra clip padding will then be useless (1.0 for float, 0.25 for double variants) as roots do not ensure enough precision on the point coordinates for now
@bourgesl
Copy link
Owner Author

Really worth to improve 2nd and 3rd order polynom solver in Marlin-math:
https://github.com/bourgesl/marlin-math

@bourgesl bourgesl moved this to In Progress in @bourgesl FOSS TODO Nov 20, 2021
@bourgesl bourgesl moved this from In Progress to Todo in @bourgesl FOSS TODO Nov 20, 2021
@bourgesl bourgesl moved this from Todo to In Progress in @bourgesl FOSS TODO Sep 24, 2022
@bourgesl bourgesl removed the status in @bourgesl FOSS TODO Nov 1, 2022
@bourgesl bourgesl moved this to Done in @bourgesl FOSS TODO Nov 1, 2022
@bourgesl
Copy link
Owner Author

bourgesl commented Nov 4, 2024

To fix marlin's bezier quad or cubic issues, I found how to solve accurately:

So happy !

See
http://people.eecs.berkeley.edu/~wkahan/Math128/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant