Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cubic curve offset computation #38

Open
bourgesl opened this issue Jan 8, 2020 · 3 comments
Open

Improve cubic curve offset computation #38

bourgesl opened this issue Jan 8, 2020 · 3 comments
Assignees
Labels

Comments

@bourgesl
Copy link
Owner

bourgesl commented Jan 8, 2020

In some case, offsetted curve may have a loop because solving the 2nd degree equation is not stable in Stroker.computeOffsetCubic().

Using twice the solution in computeOffsetQuad() based on segment intersection, is a good enough approach to make offsets stable

@bourgesl bourgesl added the bug label Jan 8, 2020
@bourgesl bourgesl self-assigned this Jan 8, 2020
@bourgesl bourgesl moved this to Hanging in @bourgesl FOSS TODO Nov 18, 2021
@bourgesl bourgesl moved this from Hanging to Todo in @bourgesl FOSS TODO Nov 20, 2021
@bourgesl
Copy link
Owner Author

bourgesl commented Dec 1, 2021

Still WIP in branch better-curves

@bourgesl bourgesl reopened this Dec 1, 2021
@bourgesl bourgesl moved this from Todo to In Progress in @bourgesl FOSS TODO Sep 24, 2022
@bourgesl
Copy link
Owner Author

bourgesl commented Nov 4, 2024

To fix marlin's bezier quad or cubic issues, I found how to solve accurately:

So happy !

See
http://people.eecs.berkeley.edu/~wkahan/Math128/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

1 participant