Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXME WHEN COORDINATES REFACTORED #2727

Open
dschwoerer opened this issue Jun 19, 2023 · 4 comments
Open

FIXME WHEN COORDINATES REFACTORED #2727

dschwoerer opened this issue Jun 19, 2023 · 4 comments

Comments

@dschwoerer
Copy link
Contributor

Should that have been fixed?

https://bout-dev.readthedocs.io/en/stable/user_docs/new_in_v5.html#fixme-when-coordinates-refactored

@ZedThree
Copy link
Member

There's some work currently in place to refactor Coordinates that will hopefully eliminate the need for geometry() entirely, so I think that's still the case.

@dschwoerer
Copy link
Contributor Author

But that should then be "New in 5.2.0"?

@ZedThree
Copy link
Member

No, the text is correct for 5.0.0 (the section heading aside). The calls to geometry() have been removed from the Coordinates ctors, so it must be called manually -- but this is already the case if the user modifies any of the metrics.

@dschwoerer
Copy link
Contributor Author

Ah, now I get your point. So we should probably change "FIXME WHEN COORDINATES REFACTORED" to "Explicit call to `Coordinates::geometry() required"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants